Expose configurable routing scorer parameters#889
Expose configurable routing scorer parameters#889pwltr wants to merge 2 commits intolightningdevkit:mainfrom
Conversation
|
I've assigned @tnull as a reviewer! |
|
🔔 1st Reminder Hey @tnull! This PR has been waiting for your review. |
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
Hmm, so far we intentionally were holding back exposing all of these fields, as many are pretty cryptic to most users. Rather it would be preferable if we could provide sane defaults.
Could you expand on what you're actually looking to change? Also note that some of these changes might conflict/be impacted by the work over at #815.
Yeah so we are in the situation that we are seeing really bad payment/probing success rate at the moment and relying on a good set of scores from a remote prober alone does not resolve the issue. From testing it seems to be necessary to also tune scoring params on the client itself, predominately bumping If we can find good defaults that would be preferable. For now we are grossly increasing |
3 participants
Summary
Adds configurable pathfinding scorer parameters so apps can tune routing behavior instead of always using LDK defaults.
It introduces two new config surfaces:
ScoringFeeParameters(maps toProbabilisticScoringFeeParameters)ScoringDecayParameters(maps toProbabilisticScoringDecayParameters)These can now be set through:
Config(scoring_fee_params,scoring_decay_params)BuilderAPIs:set_scoring_fee_params(...)set_scoring_decay_params(...)At build time,
ldk-nodenow uses configured scorer params when constructing a newProbabilisticScorer(when no persisted scorer exists) and router fee params, falling back to LDK defaults when unset.Changes and PR description created with agentic assistance